Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajoute le service provider aux données des webhooks #476

Merged

Conversation

jbfeldis
Copy link
Contributor

No description provided.

Copy link

linear bot commented Oct 10, 2024

@jbfeldis jbfeldis marked this pull request as ready for review October 18, 2024 12:19
Copy link
Member

@skelz0r skelz0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. ce n'est pas testé 🤔
  2. le code cog n'a rien à faire ici imo, pour plusieurs raisons: ça ne sert qu'à API Part, et le siret permet de récupérer via l'INSEE ce code cog (et donc on peut le récupérer coté API Part)

jbfeldis and others added 3 commits October 23, 2024 10:28
2 reasons:

1. Not used within the app
2. siret, which is a uniq id, can be used to retrieve this info on INSEE
@skelz0r skelz0r force-pushed the feature/api-3672-passer-les-infos-de-lediteur-dans-le-webhook branch from 5ab2ede to 9861e52 Compare October 23, 2024 09:28
@skelz0r
Copy link
Member

skelz0r commented Oct 23, 2024

cf mes 2 remarques + 2 commits

@skelz0r skelz0r self-requested a review October 23, 2024 13:50
@skelz0r skelz0r merged commit 4d0fe60 into develop Oct 23, 2024
12 checks passed
@skelz0r skelz0r deleted the feature/api-3672-passer-les-infos-de-lediteur-dans-le-webhook branch October 23, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants